[Do not merge] Test/sitealert banner #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
paridhi-parajuli
requested review from
slesaad
and removed request for
slesaad
|
@dzole0311 the preview is missing the icons for the banners for some reason 🤔 |
|
@slesaad looking into it |
|
@slesaad @paridhi-parajuli I found the issue and opened a PR with a fix and tested the change here in the GHG Center: #698 It was a front-end pipeline problem since one of the USWDS-provided utils was not working as expected, and we will need a veda-ui hotfix release 😞 Depending on how urgent this is, an alternative is to manually copy the few missing icons into the static directory and link them in the config file, which I could do for you. |
|
@dzole0311 thanks for the fix! no rush right now, we can pull it in from the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the addition banner, site alerts and cookie consent form to GHGC portal.
Reference : https://github.com/NASA-IMPACT/veda-ui/blob/3e9ce51e909b2eea78d4c108e8c37a9e49374ef8/mock/veda.config.js
It requires the the following env vars to be set in the .env file
COOKIE_CONSENT_FORM = 'TRUE'